feat(s2n-quic-xdp): implement tx/rx traits for shared tokio sockets #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/xdp-tokio-task
branch
from
225c870
to
a34fa7d
Compare
camshaft
force-pushed
the
camshaft/xdp-tokio-task
branch
from
a34fa7d
to
fe88c41
Compare
WesleyRosenblum
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR implements the tx/rx traits for tokio sockets, including ones behind an
Arc. This allows TX AF_XDP sockets to bepolled to drive progress rather thansend_to.Call-outs:
I changed the TX trait a bit to better capture the differences between the TX queue sending items and not having capacity to send. I've also refactored the impls into their own module to shorten the length of the file.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.