fix(s2n-quic-transport): Map poll_accept errors to documented return value #1743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #1712
Description of changes:
This change fixes our code so that our "accept" functions return what our documentation says they return. Previously they could return both Ok(None) and Err(connection::Error::Closed) to indicate the connection has been closed. Now they return Ok(None) for all errors that indicate the connection was closed.
Call-outs:
Used the #[inline] attribute because this function is small and is called in a different crate than it's defined. I think that's how it's supposed to be used?
Testing:
I manually tested that this change fixed the issue for connection::Error::Closed and connection::Error::IdleTimerExpired.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.