-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(s2n-quic): verify connection success/failure when mTLS is required #1725
Conversation
quic/s2n-quic/src/tests.rs
Outdated
// restore the network after approximately half the max handshake | ||
// timeout to allow the handshake to succeed | ||
delay(max_handshake_duration / 2).await; | ||
model.set_drop_rate(0.0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I choose the max_handshake / 2 after some experimentation. Its hard to pinpoint the sleep duration since there seems to be some interplay between the network delay, sleep and max handshake duration.
However, since we are testing all the various combinations I think it sets a good baseline for us to work from. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke offline. The delay and loss wasnt providing much value and I decided to remove it. Instead I added a success and failure case for mTLS testing.
I was really hoping to have the failure test to show that the server doesn't even accept the connection and yield to the application at all. Here's my recommended changes: |
Description of changes:
This PR adds some integration testing around connection establishment when mTLS negotiation is required. There are two test:
Call-outs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.