fix(s2n-quic-transport): reset PTO backoff once per space discard #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
previously approved these changes
Apr 20, 2023
WesleyRosenblum
previously approved these changes
Apr 20, 2023
toidiu
force-pushed
the
ak-fix_space_discard
branch
from
63d4b49
to
b79d3d9
Compare
camshaft
previously approved these changes
Apr 20, 2023
WesleyRosenblum
previously approved these changes
Apr 20, 2023
toidiu
force-pushed
the
ak-fix_space_discard
branch
from
b79d3d9
to
99e686b
Compare
camshaft
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
PTO is a loss recovery mechanism that works by sending packet probes to the peer to trigger an acknowledgement. Repeated probes are separated by a time value calculated using the round trip time estimate and a backoff factor. The backoff factor is reset each time a packet number space is discarded, as this is an indication of connection progress. During the handshake, this backoff factor was being reset each time a handshake packet was transmitted. This PR fixes this by only resetting the backoff factor once when the initial space is discarded.
Testing:
Adds an integration test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.