Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rustls-mtls): add valid certificates and tracing subscriber #1715

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

jmayclin
Copy link
Contributor

Resolved issues:

Certs are not currently valid and get rejected

ubuntu@ip-172-31-14-132:~/workspace/s2n-quic/examples/rustls-mtls/certs$ openssl x509 -in client.pem -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number: 2 (0x2)
        Signature Algorithm: ecdsa-with-SHA256
        Issuer: CN = quic-test.local CA
        Validity
            Not Before: Jan  9 21:55:45 2023 GMT
            Not After : Mar 10 21:55:45 2023 GMT
        ...

Description of changes:

  • adds new certs. These can be regenerated at any times using the generate_certs.sh script.
  • adds a tracing subscriber. We currently don't have a vanilla "dump all events to a log file" tracing subscriber example, and it would be nice to have one so that we have an example to point people towards when we ask for them to provide logs.
  • adds a Readme

Testing:

Checked the certificate validity dates with openssl, and made sure that the example build and ran.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmayclin jmayclin marked this pull request as ready for review April 18, 2023 23:10
examples/rustls-mtls/README.md Outdated Show resolved Hide resolved
examples/rustls-mtls/certs/generate_certs.sh Outdated Show resolved Hide resolved
@jmayclin jmayclin enabled auto-merge (squash) April 19, 2023 18:16
@jmayclin jmayclin merged commit 3eb3df7 into aws:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants