New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add excluded directories for main workspace #1711

Merged

camshaft merged 1 commit into main from camshaft/workspace-exclude

Apr 17, 2023

Contributor

camshaft commented Apr 17, 2023 •

edited

Loading

Description of changes:

Cargo complains about a crate depending on another crate in a subdirectory that isn't part of a workspace:

$ cargo build
error: package `/home/cameron/Projects/aws/s2n-quic/tools/xdp/s2n-quic-xdp/Cargo.toml` is a member of the wrong workspace
expected: /home/cameron/Projects/aws/s2n-quic/Cargo.toml
actual:   /home/cameron/Projects/aws/s2n-quic/tools/xdp/Cargo.toml

Adding an explicit exclude field to the root workspace fixes this issue.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


          build: add excluded directories for main workspace

e54f1de

camshaft marked this pull request as ready for review

April 17, 2023 17:32

harrisonkaiser approved these changes

View reviewed changes

camshaft merged commit d92f971 into main

camshaft deleted the camshaft/workspace-exclude branch

April 17, 2023 18:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet