perf(s2n-codec): optimize zerocopy macros #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While benchmarking the XDP code, I noticed the zerocopy functions showing up in the profile. It turns out that the from_bytes and as_bytes methods don't have
#[inline]which misses out on some optimizations.I've updated the codec to just use the Zerocopy traits as markers instead and then just interpreted the byte slice as a struct pointer (which is all those methods do).
Call-outs:
The XDP BPF programs had to be updated, which is actually a good sign that this is an improvement. The codesize of the programs all went down byte 40 bytes!
Testing:
All of the existing codec tests should cover this change. The functionality is equivalent.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.