feat(s2n-quic-xdp): add umem module #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds the last component of the libxdp port. This is the UMEM component which holds the region of memory with actual packet data. It can be indexed with either a UmemDescriptor and RxTxDescriptor. However, this is not a safe operation since descriptors can be forged and/or copied, meaning holding one doesn't guarantee uniqueness. Luckily, this API will just be internal implementation details of the XDP IO provider so I don't think we need a completely safe abstraction (which could affect performance).
Testing:
I added a simple test making sure the indexing works. I've also got an overall integration test in another branch that shows this working.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.