feat(s2n-quic-xdp): add if_xdp module #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/if_xdp
branch
2 times, most recently
from
8510776
to
3636b73
Compare
camshaft
force-pushed
the
camshaft/if_xdp
branch
from
3636b73
to
82bde64
Compare
toidiu
reviewed
Apr 11, 2023
Comment on lines
+37
to
+41
| #[derive(Copy, Clone, Debug, Default)] | ||
| #[repr(transparent)] | ||
| pub struct UmemFlags: u32 { | ||
| const UNALIGNED_CHUNK_FLAG = 1 << 0; | ||
| } |
There was a problem hiding this comment.
All of the flags are u32. You can also see the config field in libxdp. I can link this if that's helpful.
There was a problem hiding this comment.
So if I understand correctly, this is specifically matching the xdp-project interface. Yea it would be good to include a link to the xdp-project github, since this is definitely new territory for me and possible others.
| #[repr(C)] | ||
| pub struct Address { | ||
| pub family: u16, | ||
| pub flags: XdpFlags, |
tools/xdp/s2n-quic-xdp/src/if_xdp.rs
Outdated
| /// Dropped due to invalid descriptor | ||
| pub rx_invalid_descriptors: u64, | ||
| /// Dropped due to invalid descriptor | ||
| pub tx_invalid_descriptors: u32, |
There was a problem hiding this comment.
Suggested change
| pub tx_invalid_descriptors: u32, | |
| pub tx_invalid_descriptors: u64, |
There was a problem hiding this comment.
nice catch. that would have been annoying to debug 😄
toidiu
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR:
if_xdp.rsmodule, which implements the structs, flags, and definitions in the kernel.Call-outs:
The
if_xdpcould probably have been auto-generated with bindgen. However, the macro definitions aren't correctly translated, since they don't have an explicit type. I also wanted to make it a bit more ergonomic by using thebitflagscrate, expanding the struct names/fields, and adding some additional documentation and references.I also regenerated the bpf code while I was here, as a few dependencies have been updated since they were last committed.
Testing:
The xdp CI task now includes a
cargo testandcargo clippy, which will build the s2n-quic-xdp crate and run any associated tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.