Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s2n-quic-qns): Add max pacing rate and delivery rate to perf stats #1699

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

WesleyRosenblum
Copy link
Contributor

@WesleyRosenblum WesleyRosenblum commented Apr 6, 2023

Description of changes:

This change adds the maximum pacing rate and maximum delivery rate that has been observed over the reporting interval to the stats output from the Perf client and server. I've also added a header to the output.

Call-outs:

Delivery rate is only recorded for BBRv2, so if CUBIC is being used this will always report 0bps.

Testing:

Ran the perf client:

Tx Rate Rx Rate Max Cwnd        Max Inflight    Lost Packets    Wakeups Duration        Max RTT Max SRTT        PTO Count       Max Pacing Rate Max Delivery Rate
435.67Mbps      0bps    1.93MB  1.84MB  0       769     26.492ms        30.159ms        18.832736ms     0       872.70Mbps      642.06Mbps
443.62Mbps      0bps    6.30MB  3.86MB  0       791     83.642ms        62.176ms        45.982567ms     0       635.68Mbps      535.11Mbps
479.89Mbps      0bps    12.58MB 3.87MB  0       666     76.469ms        61.861ms        46.870825ms     0       794.57Mbps      509.45Mbps
479.91Mbps      0bps    18.32MB 3.87MB  0       672     77.935ms        62.372ms        46.312216ms     0       635.68Mbps      508.35Mbps
479.91Mbps      0bps    24.47MB 3.87MB  0       675     99.391ms        62.204ms        46.674211ms     0       794.57Mbps      509.96Mbps
434.74Mbps      0bps    29.46MB 3.87MB  0       711     26.479ms        64.434ms        49.190922ms     0       635.68Mbps      512.93Mbps

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WesleyRosenblum WesleyRosenblum enabled auto-merge (squash) April 7, 2023 00:59
@WesleyRosenblum WesleyRosenblum merged commit 13aec7b into main Apr 7, 2023
@WesleyRosenblum WesleyRosenblum deleted the WesleyRosenblum/perfstats branch April 7, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants