Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s2n-quic-core): Use correct delivery rate increase ratio in BBR #1697

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

WesleyRosenblum
Copy link
Contributor

Description of changes:

BBR is supposed to exit startup when 3 consecutive rounds do not increase the estimated bandwidth by 25%:

If BBR notices that there are several (three) rounds where attempts to double
the delivery rate actually result in little increase (less than 25 percent),
then it estimates that it has reached BBR.max_bw, sets BBR.filled_pipe to true,
exits Startup and enters Drain.

The ratio used to represent a 25% increase was incorrectly set to 4/3 (133%) rather than 5/4 (125%). This corrects that ratio

Testing:

Corrected the unit test too

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@WesleyRosenblum WesleyRosenblum enabled auto-merge (squash) April 5, 2023 01:21
@WesleyRosenblum WesleyRosenblum merged commit 00f5ec5 into main Apr 5, 2023
@WesleyRosenblum WesleyRosenblum deleted the WesleyRosenblum/fullpiperate branch April 5, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants