fix(s2n-quic-platform): handle ConnectionReset on Win sockets (#1448) #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #1448
Description of changes:
As discussed in #1448, Windows raises a ConnectionReset if the remote side executes a hard or abortive close. From the recvfrom API for WSAECONNRESET:
Instead of panicing when this happens, we should ignore the error and continue processing entries.
This PR is a copy of the code from #1448 as recommended by @camshaft.
Call-outs:
Testing:
Tested locally to confirm that a ConnectionReset no longer causes a panic.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.