fix(s2n-quic-core): decrease minimum allowed RTT sample to 1 microsecond #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently s2n-quic enforces a minimum RTT estimate of 1 millisecond, which may be too high a value for intra datacenter connections. I thought this might be an RFC requirement, but it looks like we just did it to save on having an
is_first_rtt_samplein theRTTEstimator(which we ended up adding back in anyway). This change reduces the minimum RTT estimate to 1 microsecond.Testing:
Updated existing unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.