Allow rustls provider to be cloned and take in Arcs #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
Currently, if you have existing
ClientConfigandServerConfigobjects from rustls, in order to feed them intos2n-quic, you need to clone the entire backing rustls config objects. This can be an extremely expensive operation memory-wise, especially if you have a large number of certificates installed.I've changed the code to allow both implementations of tls::Endpoint to be cloned. I've also implemented their respective
From<Arc<*>>traits to allow you to construct them from existing Arcs.Call-outs:
N/A
Testing:
It doesn't alter any major functionality, so if it builds, it should work.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.