fix(s2n-quic-events): correct tx error emission #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a tx error occurs in the standard queue (used for recvfrom and sendto system call) we previously emitted an rx error. This commit corrects this, so now tx failures result in tx error events.
camshaft
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tx error occurs in the standard queue (used for recvfrom and sendto system call) we previously emitted an rx error. This commit corrects this, so now tx failures result in tx error events.
Call-outs:
We don't currently have tests for these events, but if there is interest I can add some.
Testing:
Manually looked through the rest of the queue implementations and confirmed that errors corresponded to the proper methods. See call-out about unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.