add packet_len field to Packet Sent event #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a packet recorder which lets us check compare the recorded packet sent events against the packets sent on the network. We need to do a little extra bookkeeping to compare the network packets against the quic packets, but looks to work out fine in the end.
camshaft
reviewed
Jan 19, 2023
quic/s2n-quic/src/tests.rs
Outdated
| _info: &ConnectionInfo, | ||
| ) -> Self::ConnectionContext { | ||
| PacketSentContext { | ||
| packet_sent: Arc::clone(&self.packet_sent), |
There was a problem hiding this comment.
Suggested change
| packet_sent: Arc::clone(&self.packet_sent), | |
| packet_sent: self.packet_sent, |
There was a problem hiding this comment.
The compiler doesn't like that one.
cannot move out of self.packet_sent which is behind a mutable reference
move occurs because self.packet_sent has type Arc<...Mutex<Vec<...PacketSent>>>, which does not implement the Copy trait.
There was a problem hiding this comment.
Is the thought that clone is unnecessary and we should prefer to move, since the packet_sent member of PacketSentSubscriber doesn't get used again?
Some/None would be an option for that, but feels a bit heavy-handed.
There was a problem hiding this comment.
I'm dumb; I meant to add a .clone() to the end. Yes the event types are all non-copy in case we want to add non-copyable fields in the future
- run & fix clippy on latest stable toolchain - run rustfmt on nightly toolchain - prettier equality checking that Cameron suggested - remove ugly clone since address implements it - call clone on variable, rather than Arc::clone(...)
camshaft
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
#1444
Description of changes:
This PR adds a
packet_lenfield to thePacketSentevent. It also adds a unit test to check that thepacket_lenis correct.Call-outs:
I don't particularly love the location of the unit test right now, but because it relies on the network simulator and the setup methods, it feels easiest to fit it in the
s2n-quiccrate.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.