ci: ignore more broken clippy lints #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
reviewed
Dec 20, 2022
| @@ -1,6 +1,8 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| #![allow(clippy::unnecessary_cast)] // some platforms encode lengths as `u32` so we cast everything to be safe | |||
There was a problem hiding this comment.
🥇 dang sharp edges. Wondering if some tests failed or you foresaw this on your own?
There was a problem hiding this comment.
we ran into issues with it in the past. i believe it was macos so our current tests should catch it
toidiu
approved these changes
Dec 20, 2022
toidiu
reviewed
Dec 20, 2022
| @@ -10,5 +10,5 @@ | |||
| set -e | |||
|
|
|||
| cargo +nightly fmt --all -- --check | |||
| cargo +stable clippy --all-features --all-targets -- -D warnings -A clippy::derive_partial_eq_without_eq | |||
| cargo +stable clippy --all-features --all-targets -- -D warnings -A clippy::derive_partial_eq_without_eq -A clippy::manual_clamp -A clippy::uninlined_format_args | |||
There was a problem hiding this comment.
maybe also create an issue to track removing it in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Clippy released a couple of broken lints that were rolled back in beta (and eventually the next release). This PR makes an exception for them so it doesn't break our CI.
Call-outs:
The exceptions should probably be removed after the next stable release but it isn't a huge deal if it's not.
Testing:
The CI checks are all passing now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.