Remove &mut from datagram_mut #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The internal API is locking anyway, so there's no need for the &mut here. This doesn't change anything from being *possible* (you can `.clone().datagram_mut(...)` already), but it does mean that callers need that extra clone().
camshaft
approved these changes
Dec 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal API is locking anyway, so there's no need for the &mut here. This doesn't change anything from being possible (you can
.clone().datagram_mut(...)already), but it does mean that callers need that extra clone().Note that this changes a technically stable API, though I doubt there are users (since datagrams themselves are unstable). The change is also likely to be compatible with most call sites.
Testing:
No particular testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.