Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(s2n-quic-core): remove redundant assignment #1574

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

jmayclin
Copy link
Contributor

The max_ack_delay transport parameter is loaded multiple times. This commit removes that multiple load.

Description of changes:

The max_ack_delay parameter is currently loaded multiple times. This looks to be redundant, and this commit removes it.

There are no semantic changes expected with this commit. I also wouldn't be surprised if this gets optimized out by the compiler, so I don't expect any performance changes either.

Call-outs:

I have this commit under the style tag, since it isn't necessarily a bug fix. And if the compiler is optimizing this out, then it's not a perf thing either.

Testing:

Passed all unit tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The max_ack_delay transport parameter is loaded multiple times. This
commit removes that multiple load.
@jmayclin
Copy link
Contributor Author

qns / tshark failing on unrelated configuration error

 CMake Error at cmake/modules/FindPCAP.cmake:212 (message):
  You need libpcap 0.8 or later
Call Stack (most recent call first):
  CMakeLists.txt:1162 (find_package)
  CMakeLists.txt:1211 (ws_find_package)

@jmayclin jmayclin merged commit 0de6733 into aws:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants