Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: kani test for packet number map #1508

Merged
merged 2 commits into from
Mar 29, 2023
Merged

testing: kani test for packet number map #1508

merged 2 commits into from
Mar 29, 2023

Conversation

toidiu
Copy link
Contributor

@toidiu toidiu commented Sep 22, 2022

Adds a kani proof. Note that this takes approx 30 min on my mac to run.

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed? -->

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run rustfmt

quic/s2n-quic-core/src/packet/number/map.rs Outdated Show resolved Hide resolved
@camshaft
Copy link
Contributor

With the most recent kani version and using kissat the proof completes in 2s on my machine. I think we're good to merge now.

@camshaft camshaft enabled auto-merge (squash) March 29, 2023 19:38
@camshaft camshaft merged commit 1554b98 into main Mar 29, 2023
@camshaft camshaft deleted the ak-kani_pnm branch March 29, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants