fix(s2n-quic): make AsyncWrite::poll_flush a no-op

aws · Oct 9, 2024 · 8873e37 · 8873e37
1 parent 032f326
commit 8873e37
Showing 1 changed file with 14 additions and 9 deletions.
diff --git a/quic/s2n-quic/src/stream/send.rs b/quic/s2n-quic/src/stream/send.rs
@@ -413,10 +413,12 @@ macro_rules! impl_send_stream_trait {
 
             #[inline]
             fn poll_flush(
-                mut self: core::pin::Pin<&mut Self>,
-                cx: &mut core::task::Context<'_>,
+                self: core::pin::Pin<&mut Self>,
+                _cx: &mut core::task::Context<'_>,
             ) -> core::task::Poll<$crate::stream::Result<()>> {
-                Self::poll_flush(&mut self, cx)
+                // no-op - this contract relies on flushing intermediate buffers, not waiting for
+                // the peer to ACK data
+                core::task::Poll::Ready(Ok(()))
             }
 
             #[inline]
@@ -476,11 +478,12 @@ macro_rules! impl_send_stream_trait {
 
             #[inline]
             fn poll_flush(
-                mut self: core::pin::Pin<&mut Self>,
-                cx: &mut core::task::Context<'_>,
+                self: core::pin::Pin<&mut Self>,
+                _cx: &mut core::task::Context<'_>,
             ) -> core::task::Poll<std::io::Result<()>> {
-                core::task::ready!($name::poll_flush(&mut self, cx))?;
-                Ok(()).into()
+                // no-op - this contract relies on flushing intermediate buffers, not waiting for
+                // the peer to ACK data
+                core::task::Poll::Ready(Ok(()))
             }
 
             #[inline]
@@ -541,9 +544,11 @@ macro_rules! impl_send_stream_trait {
             #[inline]
             fn poll_flush(
                 self: core::pin::Pin<&mut Self>,
-                cx: &mut core::task::Context<'_>,
+                _cx: &mut core::task::Context<'_>,
             ) -> core::task::Poll<std::io::Result<()>> {
-                futures::io::AsyncWrite::poll_flush(self, cx)
+                // no-op - this contract relies on flushing intermediate buffers, not waiting for
+                // the peer to ACK data
+                core::task::Poll::Ready(Ok(()))
             }
 
             #[inline]