add has error property in response #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xueningl-az
requested review from
saikiranakula-amzn,
cslong and
huawenm
as code owners
jonlouie
reviewed
Oct 29, 2023
| @@ -20,6 +20,7 @@ public class ProjectAnalysisResult : ProjectDetails, IDisposable | |||
| public ExternalReferences ExternalReferences { get; set; } | |||
| public ProjectCompatibilityResult ProjectCompatibilityResult { get; set; } | |||
|
|
|||
| public bool HasError { get; set; } //GetCompatibilityResponse HasError | |||
There was a problem hiding this comment.
If this only signals errors from compatibility checking, can we rename it to HasCompatibilityCheckingError? Also, is it possible to save these errors to a property as well? Something like CompatibilityCheckingErrors.
jonlouie
approved these changes
Oct 30, 2023
mrkdeng
approved these changes
Oct 30, 2023
saikiranakula-amzn
approved these changes
Oct 30, 2023
huawenm
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a HasError property in CompatibilityCheckerResponse class