Merge pull request #2038 from aws/fix-duplication

add hashcode and equal for APIEntity class
aws · Oct 4, 2023 · 2c5f504 · 2c5f504
2 parents da44a3c + f0fc9e2
commit 2c5f504
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/PortingAssistant.Client.Analysis/AnalysisHandler.cs b/src/PortingAssistant.Client.Analysis/AnalysisHandler.cs
@@ -496,8 +496,20 @@ private ProjectAnalysisResult AnalyzeProject(
                                     analyzer, targetFramework,
                                     out sourceFileToCodeEntityDetails,
                                     assessmentType);
-                var compatibilityCheckerResponse = ProcessCompatibilityCheckerRequestByApplyingCache(project, rawCompatibilityCheckerRequest);
-
+
+                CompatibilityCheckerResponse compatibilityCheckerResponse;
+                if (rawCompatibilityCheckerRequest.PackageWithApis.Any())
+                {
+                    compatibilityCheckerResponse =
+                        ProcessCompatibilityCheckerRequestByApplyingCache(project, rawCompatibilityCheckerRequest);
+                }
+                else
+                {
+                    _logger.LogInformation($"no package with api entities found in project {project}. " +
+                                           $"Return empty CompatibilityCheckerResponse");
+                    compatibilityCheckerResponse = new CompatibilityCheckerResponse();
+                }
+
                 var portingActionResults = ProjectActionsToRecommendedActions.Convert(projectActions);
 
                 var nugets = analyzer.ProjectResult.ExternalReferences.NugetReferences

diff --git a/src/PortingAssistant.Compatibility.Common/Model/ApiEntity.cs b/src/PortingAssistant.Compatibility.Common/Model/ApiEntity.cs
@@ -11,5 +11,18 @@ public class ApiEntity
         public CodeEntityType CodeEntityType { get; set; }
         public string Namespace { get; set; }
         public string OriginalDefinition { get; set; } //valid for method
+
+        public override bool Equals(object obj)
+        {
+            return obj is ApiEntity entity &&
+                   CodeEntityType == entity.CodeEntityType &&
+                   Namespace == entity.Namespace &&
+                   OriginalDefinition == entity.OriginalDefinition;
+        }
+
+        public override int GetHashCode()
+        {
+            return HashCode.Combine(CodeEntityType, Namespace, OriginalDefinition);
+        }
     }
 }