Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: de-prioritize c1 #2103

Merged
merged 1 commit into from
Jul 11, 2022
Merged

fix: de-prioritize c1 #2103

merged 1 commit into from
Jul 11, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jul 11, 2022

Description
C1 has odd #CPU <-> family mapping which can cause it to be preferred by bin-packing. De-prioritize to prevent this from occurring.

How was this change tested?

  • Unit testing and make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

C1 has odd #CPU <-> family mapping which can cause it to be preferred
by bin-packing. De-prioritize to prevent this from occurring.
@tzneal tzneal requested a review from a team as a code owner July 11, 2022 14:46
@tzneal tzneal requested a review from njtran July 11, 2022 14:46
@netlify
Copy link

netlify bot commented Jul 11, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8f5eead
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62cc37d0f46cc4000991f0ff

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 1bb35e4 into aws:main Jul 11, 2022
@suket22 suket22 mentioned this pull request Jul 13, 2022
3 tasks
@tzneal tzneal deleted the deprioritize-c1-family branch July 14, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants