Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify NodePool disruption budgets impact on drift reconciliation #7483

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

josh-ferrell
Copy link
Contributor

Fixes #7036

Description
Clarify that NodePool disruption budgets can prevent NodeClaim termination when the reason is drift. Expiration is verified as unaffected by disruption budgets.

How was this change tested?
Four NodePools were created with a combination of budgets with nodes set to 0 or 10% and with reasons let unspecified, reasons set to Empty only and reasons set to Drifted only. NodePool disruption budgets with nodes set to 0 and without reasons given or with the reason Drifted given prevented nodeclaim termination after changing the AMI in the underlying EC2NodeClass. As an example the following budgets would prevent nodeclaim termination between 12AM - 12PM UTC for any reason, nodeclaim termination because of drift anytime and would allow nodeclaim termination when empty for 10% of the nodepool at a time.

budgets:
  - nodes: 10%
    reasons:
      - Empty
  - nodes: "0"
    reasons:
      - Drifted
  - duration: 12h0m0s
    nodes: "0"
    schedule: 0 12 * * mon-fri

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josh-ferrell josh-ferrell requested a review from a team as a code owner December 4, 2024 16:55
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit bb82a66
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/67508969d8b66700084d15f9
😎 Deploy Preview https://deploy-preview-7483--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12164529859

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%

Totals Coverage Status
Change from base Build 12147487832: 0.0%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

@njtran njtran merged commit 42ab06c into aws:main Dec 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarity in documentation for drifted nodes and blocking updates during a specific time
3 participants