Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update v1 migration guide #7220

Merged
merged 6 commits into from
Nov 30, 2024
Merged

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Oct 15, 2024

Fixes #N/A

Description
Performs various updates to the v1 migration guide. Highlights include:

  • Reordering sections to better indicate importance of information
  • Attaching rather than replacing the IAM policy during upgrade
  • Added clarification and examples for several steps
  • General formatting changes

How was this change tested?
make website

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner October 15, 2024 16:18
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit b9bacf0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/674a5977a880be0008ac9184
😎 Deploy Preview https://deploy-preview-7220--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jmdeal jmdeal force-pushed the docs/update-migration-guide branch 5 times, most recently from bfc923a to 3f642f6 Compare October 15, 2024 20:19
@jmdeal jmdeal force-pushed the docs/update-migration-guide branch 2 times, most recently from 67e6e96 to 3217409 Compare October 15, 2024 20:26
@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 12091925205

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.022%

Totals Coverage Status
Change from base Build 12091461232: 0.0%
Covered Lines: 5733
Relevant Lines: 8817

💛 - Coveralls

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

website/content/en/docs/upgrading/v1-migration.md Outdated Show resolved Hide resolved
website/content/en/docs/upgrading/v1-migration.md Outdated Show resolved Hide resolved
website/content/en/docs/upgrading/v1-migration.md Outdated Show resolved Hide resolved
website/content/en/docs/upgrading/v1-migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jmdeal
Copy link
Contributor Author

jmdeal commented Nov 15, 2024

/remove-lifecycle stale

engedaam
engedaam previously approved these changes Nov 29, 2024
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 13d6fc0 into aws:main Nov 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants