Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix consolidation test timing and add commit ref in metrics #3942

Merged
merged 5 commits into from
May 26, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented May 25, 2023

Fixes #

Description

  • adds git_ref as a dimension into exported cloudwatch metrics
  • fixes a timing bug with consolidation delete scale tests
  • adds consolidation delete empty scale test

How was this change tested?

  • TEST_SUITE=scale ENABLE_CLOUDWATCH=true make e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner May 25, 2023 22:40
@njtran njtran requested a review from bwagner5 May 25, 2023 22:40
@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1b4c745
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6470ec4c5185140008506879
😎 Deploy Preview https://deploy-preview-3942--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Makefile Outdated Show resolved Hide resolved
test/pkg/environment/aws/metrics.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@njtran njtran merged commit 76bbdaf into aws:main May 26, 2023
njtran added a commit to njtran/karpenter-provider-aws that referenced this pull request Jun 8, 2023
njtran added a commit to njtran/karpenter-provider-aws that referenced this pull request Jun 13, 2023
@njtran njtran deleted the scale branch December 26, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants