Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Override --system-reserved when scheduling and in kubelet parameter startup #2254

Merged
merged 4 commits into from
Aug 8, 2022
Merged

feature: Override --system-reserved when scheduling and in kubelet parameter startup #2254

merged 4 commits into from
Aug 8, 2022

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Aug 5, 2022 •
edited
Loading

Fixes #

Description

Allow users to specify

systemReserved:
   cpu: 2
   memory: 5Gi
   ephemeral-storage: 10Gi

in their .spec.kubeletConfiguration to override kubelet configuration passed into bootstrap scripts and used for shceduling

How was this change tested?

  • make test
  • Manual validation of allocatable resources on deployed nodes

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner August 5, 2022 17:09
@jonathan-innis jonathan-innis requested a review from dewjam August 5, 2022 17:09
@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 8cfd4c1
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62edf96f56903e00087cafea

@jonathan-innis jonathan-innis force-pushed the override-system-reserved branch from b644e4d to 6620d97 Compare August 5, 2022 17:11
@ellistarn
Copy link
Contributor

One minor nit about the API. Otherwise nice work!

@jonathan-innis jonathan-innis force-pushed the override-system-reserved branch 2 times, most recently from 5fef22d to 9a05883 Compare August 6, 2022 05:17
@jonathan-innis jonathan-innis force-pushed the override-system-reserved branch from 9a05883 to 8cfd4c1 Compare August 6, 2022 05:17
bwagner5
bwagner5 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice work

@jonathan-innis jonathan-innis merged commit 4ff98b0 into aws:main Aug 8, 2022
@jonathan-innis jonathan-innis mentioned this pull request Aug 8, 2022
Closed
njtran pushed a commit to njtran/karpenter-provider-aws that referenced this pull request Aug 9, 2022
@jonathan-innis @njtran
feature: Override --system-reserved when scheduling and in kubelet …
39db162 
…parameter startup (aws#2254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@dewjam dewjam Awaiting requested review from dewjam dewjam is a code owner automatically assigned from aws/karpenter

@ellistarn ellistarn Awaiting requested review from ellistarn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @ellistarn @bwagner5