Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: record provisioner requirements as valid topology domains #2173

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Jul 22, 2022

Description
This allows spreading across labels constructed via provisioner requirements.
How was this change tested?
Unit testing & deployed to EKS.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This allows spreading across labels constructed via provisioner
requirements
@tzneal tzneal marked this pull request as ready for review July 22, 2022 15:53
@tzneal tzneal requested a review from a team as a code owner July 22, 2022 15:53
@netlify
Copy link

netlify bot commented Jul 22, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ea9f0fd
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62dac811e3f61e0008b9d969

@tzneal tzneal requested a review from ellistarn July 22, 2022 15:53
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow big catch!!

@tzneal tzneal merged commit 7366126 into aws:main Jul 22, 2022
@tzneal tzneal deleted the add-requirement-label-awareness-to-topology branch July 22, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants