Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate termination event metrics #2152

Merged
merged 1 commit into from
Jul 19, 2022
Merged

fix: duplicate termination event metrics #2152

merged 1 commit into from
Jul 19, 2022

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jul 19, 2022

Fixes #

Description
Ensures that the karpenter_nodes_termination_time_seconds metric is updated once per termination. Other operations in the termination controller are idempotent so multiple passes are a non-issue.

How was this change tested?

  • Scale-up / scale-down events in EKS cluster

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner July 19, 2022 18:31
@jmdeal jmdeal requested a review from bwagner5 July 19, 2022 18:31
@netlify
Copy link

netlify bot commented Jul 19, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit bc8016a
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62d6f898aa9742000843317f

njtran
njtran reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think we should be using caches instead of sets if we can.

pkg/controllers/termination/controller.go Show resolved Hide resolved
pkg/controllers/termination/controller.go Show resolved Hide resolved
@njtran njtran merged commit a55a544 into aws:main Jul 19, 2022
suket22 pushed a commit to suket22/karpenter that referenced this pull request Jul 21, 2022
@jmdeal @suket22
fix: duplicate termination event metrics (aws#2152)
d12573c
@suket22 suket22 mentioned this pull request Jul 21, 2022
Merged
3 tasks
@jmdeal jmdeal deleted the termination-metric-patch branch September 1, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmdeal @njtran