Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pod startup summary metric #2146

Merged
merged 1 commit into from
Jul 20, 2022
Merged

feat: add pod startup summary metric #2146

merged 1 commit into from
Jul 20, 2022

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jul 18, 2022

Description
Instruments the karpenter_pods_startup_time_seconds metric as detailed in the metrics design doc.

How was this change tested?

  • Scale-up / scale-down tests in EKS cluster.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner July 18, 2022 19:25
@jmdeal jmdeal requested a review from tzneal July 18, 2022 19:25
@netlify
Copy link

netlify bot commented Jul 18, 2022 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 73799a9
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/62d7313d699ba00009b82f79

njtran
njtran reviewed Jul 18, 2022
View reviewed changes
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
@jmdeal jmdeal force-pushed the pod-startup-metrics branch 2 times, most recently from 5dbac87 to 1a2acbc Compare July 19, 2022 20:52
@jmdeal jmdeal requested review from ellistarn and njtran July 19, 2022 20:56
njtran
njtran reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm: just one style thing before approving.

pkg/controllers/metrics/pod/controller.go Outdated Show resolved Hide resolved
@jmdeal jmdeal force-pushed the pod-startup-metrics branch from 1a2acbc to 73799a9 Compare July 19, 2022 22:33
@jmdeal jmdeal requested a review from njtran July 19, 2022 22:33
@njtran njtran merged commit 28c2e3d into aws:main Jul 20, 2022
suket22 pushed a commit to suket22/karpenter that referenced this pull request Jul 21, 2022
@jmdeal @suket22
feat: add pod startup summary metric (aws#2146)
3471d96
@suket22 suket22 mentioned this pull request Jul 21, 2022
Merged
3 tasks
@vadimgusev-codefresh
Copy link
Contributor

@jmdeal great job on adding this useful metric. I've got couple feedback items:

  • If you scale up karpenter then you will have N sets of summaries, produced by every pod, but only leader will have actual numbers on them.
  • Is it possible/does it make sense to add labels like provisioner/capacity-type/node to align with the rest of the metrics?

@jmdeal jmdeal deleted the pod-startup-metrics branch September 1, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@tzneal tzneal Awaiting requested review from tzneal tzneal is a code owner automatically assigned from aws/karpenter

@ellistarn ellistarn Awaiting requested review from ellistarn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmdeal @vadimgusev-codefresh @ellistarn @njtran