Skip to content

Commit

Permalink
docs: correct information regarding default instance types (#2028)
Browse files Browse the repository at this point in the history
* doc: correct information regarding default instance types

Fixes #2027

* test: fix race with clearing maps
  • Loading branch information
tzneal authored Jun 30, 2022
1 parent 6b73164 commit ca76bf4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
10 changes: 8 additions & 2 deletions pkg/cloudprovider/aws/fake/ec2api.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,14 @@ func (e *EC2API) Reset() {
e.CalledWithCreateFleetInput.Reset()
e.CalledWithCreateLaunchTemplateInput.Reset()
e.DescribeSpotPriceHistoryOutput.Reset()
e.Instances = sync.Map{}
e.LaunchTemplates = sync.Map{}
e.Instances.Range(func(k, v any) bool {
e.Instances.Delete(k)
return true
})
e.LaunchTemplates.Range(func(k, v any) bool {
e.LaunchTemplates.Delete(k)
return true
})
e.InsufficientCapacityPools.Reset()
e.NextError.Reset()
}
Expand Down
7 changes: 1 addition & 6 deletions website/content/en/preview/provisioner.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,7 @@ Generally, instance types should be a list and not a single value. Leaving this

Review [AWS instance types](https://aws.amazon.com/ec2/instance-types/).

The default value includes all instance types with the exclusion of metal
(non-virtualized),
[non-HVM](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/virtualization_types.html),
and GPU instances.

View the full list of instance types with `aws ec2 describe-instance-types`.
The default value includes most instance types with the exclusion of [non-HVM](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/virtualization_types.html). The full list of supported instance types can be seen [here](../aws/instance-types/)

**Example**

Expand Down

0 comments on commit ca76bf4

Please sign in to comment.