Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix usage of "external" stability #639

Merged
merged 2 commits into from
Jul 19, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/codemaker/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/jsii-build-tools/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions packages/jsii-calc/lib/compliance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,11 @@ export interface SecondLevelStruct {
readonly deeperOptionalProp?: string;
}

/**
* Just because we can.
*
* @stability external
*/
export class StructPassing {
public static roundTrip(_positional: number, input: TopLevelStruct): TopLevelStruct {
return {
Expand Down
15 changes: 8 additions & 7 deletions packages/jsii-calc/test/assembly.jsii
Original file line number Diff line number Diff line change
Expand Up @@ -7808,23 +7808,24 @@
"jsii-calc.StructPassing": {
"assembly": "jsii-calc",
"docs": {
"stability": "experimental"
"stability": "external",
"summary": "Just because we can."
},
"fqn": "jsii-calc.StructPassing",
"initializer": {},
"kind": "class",
"locationInModule": {
"filename": "lib/compliance.ts",
"line": 1774
"line": 1779
},
"methods": [
{
"docs": {
"stability": "experimental"
"stability": "external"
},
"locationInModule": {
"filename": "lib/compliance.ts",
"line": 1783
"line": 1788
},
"name": "howManyVarArgsDidIPass",
"parameters": [
Expand Down Expand Up @@ -7852,11 +7853,11 @@
},
{
"docs": {
"stability": "experimental"
"stability": "external"
},
"locationInModule": {
"filename": "lib/compliance.ts",
"line": 1775
"line": 1780
},
"name": "roundTrip",
"parameters": [
Expand Down Expand Up @@ -9052,5 +9053,5 @@
}
},
"version": "0.14.1",
"fingerprint": "+yGMmfs+WJP2iATk7OXRXw8oP6Ov+VOkOf8BaxaCbN4="
"fingerprint": "31WUucZoc5uXBpVM+LdQz2noSFtdRXgTdT58JECw1ow="
}
142 changes: 8 additions & 134 deletions packages/jsii-diff/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/jsii-dotnet-jsonmodel/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ public enum Stability
{
Stable,
Experimental,
Deprecated
Deprecated,
External
}
}
2 changes: 1 addition & 1 deletion packages/jsii-dotnet-runtime-test/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/jsii-dotnet-runtime/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/jsii-java-runtime/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ public enum Level {
* The API may emit warnings. Backward compatibility is not guaranteed. APIs annotated with the {@code Deprecated}
* level should also be annotated with the standard {@link Deprecated} annotation.
*/
Deprecated
Deprecated,

/**
* This API is an representation of an API managed elsewhere and follows
* the other API's versioning model.
*/
External
}
}
2 changes: 1 addition & 1 deletion packages/jsii-kernel/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading