feat(jsii): Tag the jsii compiler version in the .jsii assemblies #420
+87
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the fully qualified version number (including the commit SHA prefix) is written in the new `jsiiVersion` field of the assembly, however in order to make this friendlier to tests, there is an option to turn over to a *short* format by setting the new `jsii.versionFormat` key in `package.json` to `'short'`. Also, slightly altered the generation of the fully qualified version name to distinguish between cases where the commit SHA was provided by the CodeBuild environment variable, versus parsed using `git rev-parse`, denoting the later is indicative of an "unreleased" version. Fixes #412
rix0rrr
approved these changes
Apr 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the fully qualified version number (including the commit SHA
prefix) is written in the new
jsiiVersionfield of the assembly,however in order to make this friendlier to tests, there is an option to
turn over to a short format by setting the new
jsii.versionFormatkey in
package.jsonto'short'.Also, slightly altered the generation of the fully qualified version
name to distinguish between cases where the commit SHA was provided by
the CodeBuild environment variable, versus parsed using
git rev-parse,denoting the later is indicative of an "unreleased" version.
Fixes #412
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.