Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsii-pacmak): handles 'default' doc component for go #4115

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

sudolibre
Copy link
Contributor

@sudolibre sudolibre commented May 22, 2023

The default values were being parsed but not emitted for Go, effectively deleting them from the generated Go code. This was already handled for other languages.

note: following the pattern seen for link, I added the extra call to this.emitComment();

resolves: 3885


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sudolibre
Copy link
Contributor Author

@RomainMuller hopefully a quick fix here

RomainMuller
RomainMuller previously approved these changes Jun 15, 2023
@mergify mergify bot dismissed RomainMuller’s stale review July 3, 2023 12:42

Pull request has been modified.

@jonathon-day
Copy link

@RomainMuller had some test failures due mistakes with manually updating snapshot file. I discovered this is built into the tooling and updated the snapshot that way. Can you approve the workflows to run when you get a chance.

RomainMuller
RomainMuller previously approved these changes Jul 18, 2023
@mergify mergify bot dismissed RomainMuller’s stale review July 18, 2023 08:49

Pull request has been modified.

RomainMuller
RomainMuller previously approved these changes Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

Merging (with squash)...

@RomainMuller
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-issues.yml without workflows permission
err-code: EF812

@mergify mergify bot dismissed RomainMuller’s stale review July 18, 2023 09:52

Pull request has been modified.

@RomainMuller RomainMuller merged commit 9085514 into aws:main Jul 18, 2023
26 checks passed
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cdk-go-v2: default values not present in documentation
4 participants