fix(kernel): Improve tagged type of wire values #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing references across the JSII language boundary, the static return type of a method is used instead of the runtime type of the object if they are not the same, even if they are compatible. This causes issues that make it impossible to up-cast from methods such as `IConstruct.findChild` that return a super-class that is expected to be up-casted to it's known dynamic type. Fixes #345
|
I think we need a test |
eladb
suggested changes
Jan 11, 2019
|
Also don't like how this doesn't cover the intermediate class case. It's not that much more work (as we've discussed via chat) and covers us for future cases where people will be confused, expecting the more correct behavior. |
|
But... does this not cover the "more correct behavior"? I don't see the difference... o_O |
|
Added the compliance tests (kernel, Java, C#). |
rix0rrr
approved these changes
Jan 15, 2019
...sii-java-runtime-test/project/src/test/java/software/amazon/jsii/testing/ComplianceTest.java
Show resolved
Hide resolved
eladb
approved these changes
Jan 15, 2019
RomainMuller
added a commit
that referenced
this pull request
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Merged
RomainMuller
added a commit
that referenced
this pull request
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing references across the JSII language boundary, the static
return type of a method is used instead of the runtime type of the
object if they are not the same, even if they are compatible. This
causes issues that make it impossible to up-cast from methods such as
IConstruct.findChildthat return a super-class that is expected to beup-casted to it's known dynamic type.
Fixes #345
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
TODO: