Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rosetta): rosetta extract fails if run after rosetta infuse #3248

Merged
merged 9 commits into from
Dec 13, 2021

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Dec 10, 2021

There is a valid use case to run rosetta extract after rosetta infuse.
However, we run into problems because we fixturize snippets
before we check the cache, and sometimes fixturizing will fail for
infused snippets (specifically, literate sources like integ.blah.lit.ts
will fail).

We do not actually need to successfully fixturize infused examples.
We rely on these examples to be in the cached tablet file and thus
do not need to be compiled and translated again. So we introduce
a new metadata tag, infuse for all infused examples. This tag,
when consumed by extract, will skip any errors associated with
that snippet.

ALSO: increased test timeout from 30000 to 50000 to allow enough
time for mac PR test to succeed.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kaizencc kaizencc requested a review from rix0rrr December 10, 2021 18:50
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 10, 2021
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Dec 13, 2021
@kaizencc kaizencc changed the title feat(rosetta): infuse metadata tag fix(rosetta): rosetta extract fails if run after rosetta infuse Dec 13, 2021
@kaizencc kaizencc removed the pr/do-not-merge This PR should not be merged at this time. label Dec 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Dec 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Merging (with squash)...

@mergify mergify bot merged commit e3ec929 into main Dec 13, 2021
@mergify mergify bot deleted the fixture-issue branch December 13, 2021 18:58
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants