feat(rosetta): JSII_ROSETTA_MAX_WORKER_COUNT limits max workers #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current behavior of rosetta (extract) is to use a number of node worker threads equal to half the number of CPU cores. On large CI/CD build hardware, this may mean creating a huge number of worker threads which causes more contention than benefit. Introduce JSII_ROSETTA_MAX_WORKER_COUNT to limit the maximum number of workers (defaults to 16). See aws/aws-cdk#14389 for more motivation from the AWS CDK.
njlynch
force-pushed
the
njlynch/rosetta-worker-threads
branch
from
320cffd to
b72c7dd
Compare
RomainMuller
approved these changes
Apr 27, 2021
RomainMuller
added
the
pr/do-not-merge
Co-authored-by: Romain Marcadier <[email protected]>
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
mergify bot
pushed a commit
to aws/aws-cdk
that referenced
this pull request
Jun 6, 2021
Our `yarn-upgrade` workflow is failing with: ```console @lerna/[email protected] ✔ **ERROR** Failed to apply patch for package jsii-rosetta at path node_modules/jsii-rosetta This error was caused because jsii-rosetta has changed since you made the patch file for it. This introduced conflicts with your patch, just like a merge conflict in Git when separate incompatible changes are made to the same piece of code. ``` Basically, its not able to apply the [rosetta patch](https://github.com/aws/aws-cdk/blob/master/patches/jsii-rosetta%2B1.28.0.patch) anymore since a new version of `jsii-rosetta` has been released which creates conflicts. The new version of rosetta [addresses](aws/jsii#2816) the problem the patch was trying to solve, so it is no longer needed (yey). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Our `yarn-upgrade` workflow is failing with: ```console @lerna/[email protected] ✔ **ERROR** Failed to apply patch for package jsii-rosetta at path node_modules/jsii-rosetta This error was caused because jsii-rosetta has changed since you made the patch file for it. This introduced conflicts with your patch, just like a merge conflict in Git when separate incompatible changes are made to the same piece of code. ``` Basically, its not able to apply the [rosetta patch](https://github.com/aws/aws-cdk/blob/master/patches/jsii-rosetta%2B1.28.0.patch) anymore since a new version of `jsii-rosetta` has been released which creates conflicts. The new version of rosetta [addresses](aws/jsii#2816) the problem the patch was trying to solve, so it is no longer needed (yey). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior of rosetta (extract) is to use a number of node worker
threads equal to half the number of CPU cores. On large CI/CD build hardware,
this may mean creating a huge number of worker threads which causes more
contention than benefit.
Introduce
JSII_ROSETTA_MAX_WORKER_COUNTto limit the maximum number of workers(defaults to
16).See aws/aws-cdk#14389 for more motivation from the AWS CDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.