fix(kernel + java): skip overrides of private methods/properties #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2018 10:52
jsii-kernel will ignore override requests for methods/properties that resolve on the object but are not defined in the public API of the type. java runtime will not request overrides for methods/properties that use "private" accessibility. Fixes #244
RomainMuller
reviewed
Oct 5, 2018
...sii-java-runtime-test/project/src/test/java/software/amazon/jsii/testing/ComplianceTest.java
Show resolved
Hide resolved
added 3 commits
October 5, 2018 21:24
jsii-kernel will ignore override requests for methods/properties that resolve on the object but are not defined in the public API of the type. java runtime will not request overrides for methods/properties that use "private" accessibility. Fixes #244
|
@RomainMuller let me know if this looks okay |
RomainMuller
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii-kernel will ignore override requests for methods/properties that
resolve on the object but are not defined in the public API of the
type.
java runtime will not request overrides for methods/properties that
use "private" accessibility.
Fixes #244
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.