fix(go): invalid major version suffix for submodules and jsii init #2519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major version suffix introduced in #2507 was added at the end of the full module name, but for submodules, the suffix is needed only after the root package name. Additionally, the `_init_` import failed to include the major version suffix as well. In order to cover these cases in tests, change the version of `jsii-calc` to `3.20.1` so that it will be a MV larger then 2.0. Fixes #2507
RomainMuller
approved these changes
Feb 3, 2021
added 4 commits
February 3, 2021 12:58
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major version suffix introduced in #2507 was added at the end of the full module name, but for submodules, the suffix is needed only after the root package name.
Additionally, the
_init_import failed to include the major version suffix as well.In order to cover these cases in tests, change the version of
jsii-calcto3.20.120and@scope/jsii-calc-base-of-baseto2.1.1so that it will be a MV larger then 2.0 and we can verify this works both from top-level modules, submodules and transitive local dependencies.Fixes #2507
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.