Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): Optional any represented as required #237

Merged
merged 2 commits into from
Sep 19, 2018
Merged

fix(jsii): Optional any represented as required #237

merged 2 commits into from
Sep 19, 2018

Commits on Sep 18, 2018

  1. fix(jsii): Optional any represented as required 

    Optional parameters and properties typed `any` would be represented as
required, despite the code unambiguously suggests the opposite. This is
due to the fact that `any` implicitly covers `null` and `undefined`.
This change fixes this by adding a specific provision for the question
mark token in the declarations of those, and adds compliance test
coverage for the same.

Fixes #230
    @RomainMuller
    RomainMuller committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    74770c7 View commit details
    Browse the repository at this point in the history

  2. Mark all any types as optional.

    @RomainMuller
    RomainMuller committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    6490d96 View commit details
    Browse the repository at this point in the history