fix(java): exception is logged when Java VM is shutting down #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guards against the `IllegalStateException` that will be thrown upon attempting to remove a shutdown hook during VM shut down. In such cases, the removal is no longer possible nor necessary, so the exception can be safely ignored. Fixes #2303
RomainMuller
added
bug
RomainMuller
commented
Dec 3, 2020
Comment on lines
+123
to
+129
|
|
||
| <!-- https://mvnrepository.com/artifact/javax.annotation/javax.annotation-api --> | ||
| <dependency> | ||
| <groupId>javax.annotation</groupId> | ||
| <artifactId>javax.annotation-api</artifactId> | ||
| <version>\${javax-annotations.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
This improves compat with "more recent" JDKs (where the "built-in" @javax.annotations.* was moved to a different package).
rix0rrr
approved these changes
Dec 4, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guards against the
IllegalStateExceptionthat will be thrown uponattempting to remove a shutdown hook during VM shut down. In such cases,
the removal is no longer possible nor necessary, so the exception can be
safely ignored.
Fixes #2303
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.