feat(jsii): support multiple class declaration sites #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classes can have members added to them in multiple declarations. Combine all sites into a single class model.
4 tasks
eladb
approved these changes
Jan 26, 2019
RomainMuller
approved these changes
Jan 28, 2019
| ts.DiagnosticCategory.Warning, | ||
| `Ignoring un-handled ${ts.SyntaxKind[memberDecl.kind]} member`); | ||
| if (!type.isClass()) { | ||
| throw new Error('Oh no'); |
There was a problem hiding this comment.
The alternative is "this shouldn't happen" :)
RomainMuller
added a commit
that referenced
this pull request
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Merged
RomainMuller
added a commit
that referenced
this pull request
Feb 4, 2019
### Bug Fixes * remove use of private API ([#351](#351)) ([874cbac](874cbac)), closes [#350](#350) * **jsii-dotnet-runtime:** Fix EPIPE on Windows. ([1d7cc8b](1d7cc8b)), closes [#341](#341) * **jsii-dotnet-runtime:** Redirect to STDERR. ([e20f401](e20f401)) * **kernel:** Improve tagged type of wire values ([#346](#346)) ([8ea39ac](8ea39ac)), closes [#345](#345) ### Features * **jsii:** support multiple class declaration sites ([#348](#348)) ([4ecf28c](4ecf28c)) * Generate NuGet symbol and source packages ([#243](#243)) ([aafd405](aafd405))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes can have members added to them in multiple declarations.
Combine all sites into a single class model.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.