-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rosetta): rosetta extract
fails if run after rosetta infuse
#3248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
requested changes
Dec 13, 2021
rix0rrr
approved these changes
Dec 13, 2021
kaizencc
changed the title
feat(rosetta): infuse metadata tag
fix(rosetta): Dec 13, 2021
rosetta extract
fails if run after rosetta infuse
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a valid use case to run
rosetta extract
afterrosetta infuse
.However, we run into problems because we
fixturize
snippetsbefore we check the cache, and sometimes
fixturizing
will fail forinfused snippets (specifically, literate sources like
integ.blah.lit.ts
will fail).
We do not actually need to successfully
fixturize
infused examples.We rely on these examples to be in the cached tablet file and thus
do not need to be compiled and translated again. So we introduce
a new metadata tag,
infuse
for all infused examples. This tag,when consumed by
extract
, will skip any errors associated withthat snippet.
ALSO: increased test timeout from
30000
to50000
to allow enoughtime for mac PR test to succeed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.