Skip to content

Commit

Permalink
fix(jsii): annotation '@internal' causes missing type declarations do…
Browse files Browse the repository at this point in the history
…wnstream (#2172)

Stop setting `stipInternal: true` in `tsconfig.json` files, as this makes it impossible
to mark intentionally unexported types as `@internal` without causing downstream
compilation failures due to missing type declarations.

Fixes #1947
Related to #1830 

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
  • Loading branch information
RomainMuller authored Oct 23, 2020
1 parent b4fc141 commit e80a4f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/jsii/lib/compiler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const BASE_COMPILER_OPTIONS: ts.CompilerOptions = {
strict: true,
strictNullChecks: true,
strictPropertyInitialization: true,
stripInternal: true,
stripInternal: false,
target: ts.ScriptTarget.ES2018,
};

Expand Down

0 comments on commit e80a4f7

Please sign in to comment.