fix(rosetta): diagnostics from infused snippets were not ignored (#3282)

Recently we implemented the `infused` metadata that turns `strict=false`
and `loose=true` for the specific snippet. However we still output the
diagnostics along with other snippets (with `isError=true`). One thing we
could do is make these diagnostics `isError=false`, but I argue that we
want to ignore these diagnostics entirely. They aren't actually diagnostics;
we will find them in the cache and they do compile.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

packages/jsii-rosetta/lib/translate.ts

@@ -57,7 +57,9 @@ export class Translator {
       }),
     );
 
-    this.#diagnostics.push(...translator.diagnostics);
+    if (snip.parameters?.infused === undefined) {
+      this.#diagnostics.push(...translator.diagnostics);
+    }
 
     return TranslatedSnippet.fromSchema({
       translations: {

packages/jsii-rosetta/test/commands/extract.test.ts

@@ -456,7 +456,7 @@ test('infused examples skip loose mode', async () => {
   try {
     const cacheToFile = path.join(otherAssembly.moduleDirectory, 'test.tabl.json');
 
-    // Without exampleMetadata infused=true, expect an error
+    // Without exampleMetadata infused, expect an error
     await expect(
       extract.extractSnippets([otherAssembly.moduleDirectory], {
         cacheToFile,
@@ -465,8 +465,7 @@ test('infused examples skip loose mode', async () => {
     ).rejects.toThrowError(/Sample uses literate source/);
 
     // Add infused=true to metadata and update assembly
-    otherAssembly.assembly.types!['my_assembly.ClassA'].docs!.custom!.exampleMetadata =
-      'lit=integ.test.ts infused=true';
+    otherAssembly.assembly.types!['my_assembly.ClassA'].docs!.custom!.exampleMetadata = 'lit=integ.test.ts infused';
     await otherAssembly.updateAssembly();
 
     // Expect same function call to succeed now
@@ -484,6 +483,44 @@ test('infused examples skip loose mode', async () => {
   }
 });
 
+test('infused examples have no diagnostics', async () => {
+  const otherAssembly = await TestJsiiModule.fromSource(
+    {
+      'index.ts': `
+      /**
+       * ClassA
+       * 
+       * @exampleMetadata infused
+       * @example x
+       */
+      export class ClassA {
+        public someMethod() {
+        }
+      }
+      `,
+    },
+    {
+      name: 'my_assembly',
+      jsii: {
+        ...DUMMY_JSII_CONFIG,
+      },
+    },
+  );
+  try {
+    const cacheToFile = path.join(otherAssembly.moduleDirectory, 'test.tabl.json');
+
+    const results = await extract.extractSnippets([otherAssembly.moduleDirectory], {
+      cacheToFile,
+      includeCompilerDiagnostics: true,
+      loose: false,
+    });
+
+    expect(results.diagnostics).toEqual([]);
+  } finally {
+    await otherAssembly.cleanup();
+  }
+});
+
 class MockTranslator extends RosettaTranslator {
   public constructor(opts: RosettaTranslatorOptions, translatorFn: jest.Mock) {
     super(opts);