chore: make error message about statics more descriptive (#253)

Add a 'non-const' qualifier to indicate that you probably forgot to add 'const' on your 'public static' properties.
aws · Oct 9, 2018 · 879d5db · 879d5db
1 parent 7e600f9
commit 879d5db
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 9 deletions.
diff --git a/packages/jsii/lib/validator.ts b/packages/jsii/lib/validator.ts
@@ -75,7 +75,7 @@ function _defaultValidations(): ValidationFunction[] {
             if (member.static && (member as spec.Property).const) { continue; }
             if (member.name && member.name !== Case.camel(member.name)) {
                 diagnostic(ts.DiagnosticCategory.Error,
-                            `Method and property names must use camelCase: ${member.name}`);
+                            `Method and non-static non-readonly property names must use camelCase: ${member.name}`);
             }
         }
     }

diff --git a/packages/jsii/test/negatives/neg.method-name.1.ts b/packages/jsii/test/negatives/neg.method-name.1.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: METHOD
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: METHOD
 
 export class MyClass {
     public METHOD() {

diff --git a/packages/jsii/test/negatives/neg.method-name.2.ts b/packages/jsii/test/negatives/neg.method-name.2.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: hello_world
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: hello_world
 
 export class MyClass {
     public hello_world() {

diff --git a/packages/jsii/test/negatives/neg.property-name.1.ts b/packages/jsii/test/negatives/neg.property-name.1.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: PROP
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: PROP
 
 export class MyClass {
     public PROP?: number;

diff --git a/packages/jsii/test/negatives/neg.property-name.2.ts b/packages/jsii/test/negatives/neg.property-name.2.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: my_Prop
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: my_Prop
 
 export class MyClass {
     public my_Prop?: number;

diff --git a/packages/jsii/test/negatives/neg.static-method-name.1.ts b/packages/jsii/test/negatives/neg.static-method-name.1.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: MethodIsNotCamelCase
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: MethodIsNotCamelCase
 
 export class MyClass {
     MethodIsNotCamelCase() {

diff --git a/packages/jsii/test/negatives/neg.static-method-name.ts b/packages/jsii/test/negatives/neg.static-method-name.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: METHOD
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: METHOD
 
 export class MyClass {
     METHOD() {

diff --git a/packages/jsii/test/negatives/neg.static-prop-name.1.ts b/packages/jsii/test/negatives/neg.static-prop-name.1.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: Prop
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: Prop
 
 export class MyClass {
     static get Prop() {

diff --git a/packages/jsii/test/negatives/neg.static-prop-name.2.ts b/packages/jsii/test/negatives/neg.static-prop-name.2.ts
@@ -1,4 +1,4 @@
-///!MATCH_ERROR: Method and property names must use camelCase: PROP
+///!MATCH_ERROR: Method and non-static non-readonly property names must use camelCase: PROP
 
 export class MyClass {
     static get PROP() {