-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove support for down-leveling of TypeScript declarations files to ts3.9 to improve performance #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting test failures I'm not getting locally. I'll figure that out |
Let's probably not make this a |
HBobertz
changed the title
chore: remove downlevel-dts for performance improvement purposes
fix: remove downlevel-dts for performance improvement purposes
Nov 12, 2024
Signed-off-by: github-actions <[email protected]>
mrgrain
changed the title
fix: remove downlevel-dts for performance improvement purposes
fix!: remove down-leveling of TypeScript declarations files to TS3.9 to improve performance
Nov 12, 2024
mrgrain
reviewed
Nov 12, 2024
mrgrain
reviewed
Nov 12, 2024
mrgrain
reviewed
Nov 12, 2024
mrgrain
requested changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes left
Co-authored-by: Momo Kornher <[email protected]> Signed-off-by: Hogan Bobertz <[email protected]>
Co-authored-by: Momo Kornher <[email protected]> Signed-off-by: Hogan Bobertz <[email protected]>
Co-authored-by: Momo Kornher <[email protected]> Signed-off-by: Hogan Bobertz <[email protected]>
Signed-off-by: github-actions <[email protected]>
mrgrain
approved these changes
Nov 13, 2024
mrgrain
changed the title
fix!: remove down-leveling of TypeScript declarations files to TS3.9 to improve performance
feat!: remove support for down-leveling of TypeScript declarations files to ts3.9 to improve performance
Nov 13, 2024
mrgrain
changed the title
feat!: remove support for down-leveling of TypeScript declarations files to ts3.9 to improve performance
feat: remove support for down-leveling of TypeScript declarations files to ts3.9 to improve performance
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This PR removes the TypeScript declaration file down-leveling feature from the JSII compiler to address significant performance issues. Our benchmarks show that >50% of the JSII compile time is spent in the
downlevel-dts
dependency, causing JSII to be 2.7x slower than standard TypeScript compilation. The down-leveling feature was originally added to support TypeScript versions down to 3.9, but analysis shows minimal usage - none of our AWS CDK codebase uses this feature, and only about 12 non-fork repositories on GitHub would be affected by its removal, additionally typescript 3.9 and earlier have been EOL for quite a while on definitively typed.If you found this pr because removing this feature impacted your builds, it is likely because you have this pattern somewhere in your codebase. Simply refactor that pattern and rebuild. Ensure you also are not seeing the below typesVersion in your app's package.json
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.