Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all Gremlin message serializer formats for Neptune #685

Merged
merged 10 commits into from
Sep 20, 2024

Conversation

michaelnchin
Copy link
Member

@michaelnchin michaelnchin commented Aug 28, 2024

Issue #, if available: N/A

Description of changes:

  • Support passing all GraphSON and GraphBinary TinkerPop serialization formats in the message_serializer field of %%graph_notebook_config.
  • Enforce connection_protocol -> http for certain serializers unsupported by GremlinPython driver
  • Change default connection_protocol from ws -> http, and message_serializer from graphsonv3 -> GraphSONUntypedMessageSerializerV1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@michaelnchin michaelnchin marked this pull request as ready for review September 18, 2024 23:34
@michaelnchin michaelnchin merged commit 8fa1749 into main Sep 20, 2024
4 checks passed
@michaelnchin michaelnchin deleted the gremlin-expanded-serializers branch September 20, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant