Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EncryptionKey optional in Neptune CloudFormation template #663

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Starting with v1.31.6, this file will contain a record of major features and upd
## Upcoming

- Removed unused options from `%load`([Link to PR](https://github.com/aws/graph-notebook/pull/662))
- Made EncryptionKey optional in Neptune CloudFormation template ([Link to PR](https://github.com/aws/graph-notebook/pull/663))

## Release 4.5.1 (July 31, 2024)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ Conditions:
Fn::Equals:
- !Ref SageMakerNotebookRoleArn
- ""
UseEncryptionKey:
Fn::Not:
- Fn::Equals:
- Ref: EncryptionKey
- ""

Resources:
NeptuneNotebookInstance:
Expand Down Expand Up @@ -133,7 +138,10 @@ Resources:
- Key: aws-neptune-resource-id
Value: !Ref NeptuneClusterResourceId
KmsKeyId:
Ref: EncryptionKey
Fn::If:
- UseEncryptionKey
- Ref: EncryptionKey
- Ref: AWS::NoValue

NeptuneNotebookInstanceLifecycleConfig:
Type: AWS::SageMaker::NotebookInstanceLifecycleConfig
Expand Down
Loading